[webkit-reviews] review denied: [Bug 81666] (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro : [Attachment 132828] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 20 08:23:49 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied Konrad Piascik <kpiascik at rim.com>'s
request for review:
Bug 81666: (r110063) m_mouseDownMayStartDrag is used without being behind the
ENABLE(DRAG_SUPPORT) macro
https://bugs.webkit.org/show_bug.cgi?id=81666
Attachment 132828: Patch
https://bugs.webkit.org/attachment.cgi?id=132828&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
Better do it like this:
if (m_mousePressed && m_mouseDownMayStartSelect &&
#if ENABLE(DRAG_SUPPORT)
!m_mouseDownMayStartDrag &&
#endif
m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
More information about the webkit-reviews
mailing list