[webkit-reviews] review granted: [Bug 80873] Removing HTMLTrackElement does not delete TextTrack : [Attachment 131408] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 80873: Removing HTMLTrackElement does not delete TextTrack
https://bugs.webkit.org/show_bug.cgi?id=80873

Attachment 131408: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=131408&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=131408&action=review


r=me

> Source/WebCore/html/HTMLMediaElement.h:208
>      virtual void trackWasAdded(HTMLTrackElement*);
> -    virtual void trackWasRemoved(HTMLTrackElement*);
> +    virtual void trackWillBeRemoved(HTMLTrackElement*);

I think the usual naming pattern is didAddTrack/willRemoveTrack