[webkit-reviews] review denied: [Bug 81294] Web Inspector: TypeBuilder: reduce raw methods visibility in generated types. : [Attachment 132166] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 81294: Web Inspector: TypeBuilder: reduce raw methods visibility in
generated types.
https://bugs.webkit.org/show_bug.cgi?id=81294

Attachment 132166: Patch
https://bugs.webkit.org/attachment.cgi?id=132166&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132166&action=review


One nit + you should run it through EWS.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1229
> +	       //COMPILE_ASSERT(false, weird_old_code);

We don't commit commented out code.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1247
> +	   // return Builder<NoFieldsSet>(adoptRef(new %s()));

ditto