[webkit-reviews] review denied: [Bug 81558] Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API : [Attachment 132670] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 81558: Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network
and DOM domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=81558

Attachment 132670: Patch
https://bugs.webkit.org/attachment.cgi?id=132670&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132670&action=review


So why do the tests fail?

> Source/WebCore/inspector/CodeGeneratorInspector.py:2261
> +

nit: 3 blank lines?

> Source/WebCore/inspector/InjectedScript.cpp:176
> +	   RefPtr<TypeBuilder::Runtime::RemoteObject> result =
TypeBuilder::Runtime::RemoteObject::create()

Wrap should never through. We should return ErrorString in this case instead.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:414
> +	   // FIXME: initialize root or error string param.

I am not sure I get the comment right. What you should do here is return
ErrorString claiming that document is not available.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1557
> +	   // FIXME: make a proper default value or return error message.

return error.