[webkit-reviews] review denied: [Bug 71788] <area>-tag within <map> can get focus when it is hidden : [Attachment 132564] Patch.

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has denied Antaryami Pandia
<antaryami.pandia at motorola.com>'s request for review:
Bug 71788: <area>-tag within <map> can get focus when it is hidden
https://bugs.webkit.org/show_bug.cgi?id=71788

Attachment 132564: Patch.
https://bugs.webkit.org/attachment.cgi?id=132564&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
This doesn't seem like the right approach. For one, I don't think checking for
a renderer handles all visibility cases properly (e.g. visibility:hidden).

To me, the bug appears to be that HTMLAreaElement::isKeyboardFocusable() is
lying to us by returning true even though the element is not visible and
therefore not focusable. Other focusable nodes return false from
isKeyboardFocusable() in this case (e.g. HTMLFormControlElement), so
HTMLAraeElement should do this as well. In fact, it looks like the logic you
want already exists in Node::isFocusable(), so the bug appears to be that
HTMLAreaElement isn't properly delegating to its superclass.