[webkit-reviews] review granted: [Bug 80981] [GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API : [Attachment 132213] Updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Antaryami Pandia
<antaryami.pandia at motorola.com>'s request for review:
Bug 80981: [GTK] [WK2] Add javascript clipboard functionality settings to
WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=80981

Attachment 132213: Updated patch
https://bugs.webkit.org/attachment.cgi?id=132213&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132213&action=review


Do you have commit access? If so can you fix the following small nits and land
this?

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:853
> +	* Whether JavaScript can access Clipboard. The default value is %FALSE.
If

can access Clipboard -> can access the clipboard

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:854
> +	* set to %TRUE, then it allows cut, copy and pastes command to be
executed when

pastes command -> paste commands

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2164
> + * Returns: %TRUE If javascript-can-access-clipboard support is enabled or
%FALSE otherwise.

support is enabled -> is enabled

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp:207
> +    // By default, JavaScript can access clipboard is disabled.

By default, JavaScript cannot access the clipboard.