[webkit-reviews] review granted: [Bug 81602] Fix more WTF header include paths in WebCore : [Attachment 132734] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 81602: Fix more WTF header include paths in WebCore
https://bugs.webkit.org/show_bug.cgi?id=81602

Attachment 132734: Patch
https://bugs.webkit.org/attachment.cgi?id=132734&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132734&action=review


Looks good, though I think there are some style issues with the order of
includes, unless I'm mistaken about the whole thing. Perhaps you could fix them
all before landing?

> Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:26
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Shouldn't this go at the bottom of the list now?

> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:37
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Ditto.

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:27
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Ditto.

> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:28
> -#include "GOwnPtr.h"
> +
> +#include <wtf/gobject/GOwnPtr.h>

I've been telling people not to put a newline between WebCore headers and
system headers, but if it's not a problem I'll stop. :)

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:38
>  #include <gst/pbutils/missing-plugins.h>
> +
> +#include <wtf/Noncopyable.h>

Extra newline here

> Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:25
> +#include <wtf/gobject/GOwnPtr.h>

To the bottom. I'm not sure why the style bot isn't complaining about this...

> Source/WebCore/platform/graphics/pango/FontPango.cpp:38
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Ditto.

> Source/WebCore/platform/gtk/ContextMenuGtk.cpp:23
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Ditto.

> Source/WebCore/platform/gtk/FileSystemGtk.cpp:26
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

Ditto.

> Source/WebCore/platform/gtk/GtkPopupMenu.cpp:30
> -#include "GOwnPtr.h"
> +#include <wtf/gobject/GOwnPtr.h>

I guess all of these need to be fixed?

> Source/WebCore/platform/text/gtk/TextCodecGtk.h:33
>  #include <glib.h>

Looks like this one was out of order to begin with. Might be a good idea to fix
it now.