[webkit-reviews] review canceled: [Bug 81479] [chromium] Transfer wheel flings to main thread if we hit a region that can't be scrolled from the compositor thread : [Attachment 132731] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has canceled James Robinson
<jamesr at chromium.org>'s request for review:
Bug 81479: [chromium] Transfer wheel flings to main thread if we hit a region
that can't be scrolled from the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=81479

Attachment 132731: Patch
https://bugs.webkit.org/attachment.cgi?id=132731&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132731&action=review


> Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:267
> +	   OwnPtr<PlatformGestureCurve> flingCurve =
TouchFlingPlatformGestureCurve::create(FloatPoint(gestureEvent.deltaX,
gestureEvent.deltaY));

note about directions:

Before this patch, the curve was created in the -deltaX / -deltaY direction and
the scrollBy() increment was flipped again in
WebCompositorInputHandlerImpl::scrollBy() (see line 315 pre-patch).  I changed
this here to match what WebViewImpl does - the curve is generated in the
+deltaX / +deltaY direction and the scrollBy applies it without inverting so I
wouldn't have to invert again when passing out to the main thread.

> Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:369
> +    // The second call should start scrolling in the -X direction.

this flipped because we don't invert inside scrollBy() any more, see comment
above.