[webkit-reviews] review granted: [Bug 81552] [chromium] Push culled tiles that are prepainted : [Attachment 132678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 17:27:40 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81552: [chromium] Push culled tiles that are prepainted
https://bugs.webkit.org/show_bug.cgi?id=81552

Attachment 132678: Patch
https://bugs.webkit.org/attachment.cgi?id=132678&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132678&action=review


I like this one better too.  One small nit:

> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-432
> -		       tile->m_updateCulled = true;

Can you add an assert(!tile->m_updated) here, since this would cause issues if
m_updateRect got touched but somehow m_updated was true?


More information about the webkit-reviews mailing list