[webkit-reviews] review granted: [Bug 81595] webkitpy: clean up some port._filesystem references to not reference private members : [Attachment 132725] fix nit in write_image_diff_files() as well

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 81595: webkitpy: clean up some port._filesystem references to not reference
private members
https://bugs.webkit.org/show_bug.cgi?id=81595

Attachment 132725: fix nit in write_image_diff_files() as well
https://bugs.webkit.org/attachment.cgi?id=132725&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132725&action=review


OK.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:71
> -		   if port.host.filesystem.exists(expected_filename):
> +		   if self._filesystem.exists(expected_filename):

In general getting away from using "port" for these sorts of things seems good.
 The goal being to make "port" less of the hub/god object.