[webkit-reviews] review granted: [Bug 81153] WebKit2: create sandbox extensions for files that are dropped in an input control : [Attachment 132686] Patch5

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 81153: WebKit2: create sandbox extensions for files that are dropped in an
input control
https://bugs.webkit.org/show_bug.cgi?id=81153

Attachment 132686: Patch5
https://bugs.webkit.org/attachment.cgi?id=132686&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132686&action=review


> Sorry, but I don't get this. DragDestinationAny was already UINT_MAX and has
not changed. Could you explain?

Had a look at this with Enrica. All these values are actually exclusive. The
reason this is a bitmap is that clients provide allowed actions in the form of
a single value. Eventually, it may be better to decouple WebKit1 API from
WebCore logic here, and have more sensible DragAction.h.

Enrica is going to improve comments when landing.

> Source/WebKit2/Shared/mac/SandboxExtensionMac.mm:111
> +void SandboxExtension::HandleArray::resize(size_t size)
> +{
> +    if (!size)
> +	   return;
> +
> +    if (m_data)
> +	   delete[] m_data;
> +
> +    m_data = new SandboxExtension::Handle[size];
> +    m_size = size;
> +}

This is not a proper resize - a resize doesn't delete original data. Please
rename.