[webkit-reviews] review granted: [Bug 81553] [New Multicolumn] Stub out new classes to represent the region boxes for columns. : [Attachment 132653] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 13:51:32 PDT 2012


mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 81553: [New Multicolumn] Stub out new classes to represent the region boxes
for columns.
https://bugs.webkit.org/show_bug.cgi?id=81553

Attachment 132653: Patch
https://bugs.webkit.org/attachment.cgi?id=132653&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=132653&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.h:35
> +// object, we significantly reduce the # of unique RenderObjects required to
represent columns.

Spell out “number”?

> Source/WebCore/rendering/RenderRegionSet.h:40
> +// By combining runs of same-size columns or pages into a single object, we
significantly reduce the # of unique RenderObjects

Ditto.


More information about the webkit-reviews mailing list