[webkit-reviews] review denied: [Bug 81446] Cache the type string of JavaScript object : [Attachment 132452] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 81446: Cache the type string of JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=81446

Attachment 132452: Patch
https://bugs.webkit.org/attachment.cgi?id=132452&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132452&action=review


Approach looks good. r- because it doesn't build on all platforms.

Also, one comment below.

> Source/JavaScriptCore/runtime/JSValue.cpp:NaN
>  JSString* JSValue::toStringSlowCase(ExecState* exec) const

Please add common strings for all the JSValue::toString strings. These can be
very common just like the type string case.