[webkit-reviews] review granted: [Bug 81529] [chromium] Invalidate/update evicted tiles during commit : [Attachment 132617] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 19 13:05:15 PDT 2012
Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81529: [chromium] Invalidate/update evicted tiles during commit
https://bugs.webkit.org/show_bug.cgi?id=81529
Attachment 132617: Patch
https://bugs.webkit.org/attachment.cgi?id=132617&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132617&action=review
Sorry for not catching this issue the first time through review.
> Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:370
> + EXPECT_TRUE(layerImpl->hasTileAt(0, 0));
> + EXPECT_FALSE(layerImpl->hasTileAt(0, 1));
Can you also verify after a pushPropertiesTo that neither tile is there? I
don't think we have any test related to that.
More information about the webkit-reviews
mailing list