[webkit-reviews] review granted: [Bug 81269] [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent : [Attachment 132603] Updated patch, resolved conflicts in WebPage_p.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 10:57:44 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Mike Lattanzio <mlattanzio at rim.com>'s
request for review:
Bug 81269: [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate
UserAgent
https://bugs.webkit.org/show_bug.cgi?id=81269

Attachment 132603: Updated patch, resolved conflicts in WebPage_p.h
https://bugs.webkit.org/attachment.cgi?id=132603&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132603&action=review


LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:5683
> +	   BlackBerry::Platform::DeviceInfo* info =
BlackBerry::Platform::DeviceInfo::instance();

You can probably leave off BlackBerry:: prefix.


More information about the webkit-reviews mailing list