[webkit-reviews] review granted: [Bug 81477] CSS3 calc: make mask images work with mixed percent/absolute : [Attachment 132514] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 19 10:23:12 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 81477: CSS3 calc: make mask images work with mixed percent/absolute
https://bugs.webkit.org/show_bug.cgi?id=81477
Attachment 132514: Patch
https://bugs.webkit.org/attachment.cgi?id=132514&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Sigh. So much duplicate code. It's not your fault though. If you wanted to do a
cleanup patch after this, you could move the duplicated code in mapFillSize
into a static helper function (i.e. lines 4230-4239 are identical to
4241-4250). r=me if you decide to do that.
More information about the webkit-reviews
mailing list