[webkit-reviews] review requested: [Bug 81196] IETC HTML5: verify HTMLDataListElement - instanceof HTMLDataListElement fails. : [Attachment 132576] Updated Patch with review comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 07:16:27 PDT 2012


Deepak Sherveghar <bpwv64 at motorola.com> has asked  for review:
Bug 81196: IETC HTML5: verify HTMLDataListElement - instanceof
HTMLDataListElement fails.
https://bugs.webkit.org/show_bug.cgi?id=81196

Attachment 132576: Updated Patch with review comments.
https://bugs.webkit.org/attachment.cgi?id=132576&action=review

------- Additional Comments from Deepak Sherveghar <bpwv64 at motorola.com>
> HTM5 -> HTML5
> HTMLData*l*istElement -> HTMLDataListElement 
Done.

> You need to update other tests such as
LayoutTests/fast/dom/window/window-properties.html.
I added 'HTMLDataListElement' to
LayoutTests/fast/dom/Window/resources/window-properties.js.

Following tests needs to be rebaselined:
1. fast/dom/Window/window-properties.html 
2. fast/dom/Window/window-property-descriptors.html.

I have rebaselined it for GTK platform, for rest of the platforms I have added
them to test_Expectations.txt/Skipped.

Since the above mentioned tests cover this change, I have removed the Layout
test that I had copied earlier from IETC test suite.


More information about the webkit-reviews mailing list