[webkit-reviews] review granted: [Bug 81312] [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h : [Attachment 132214] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 81312: [BlackBerry] Upstream the BlackBerry change to
platform/PlatformKeyboardEvent.h
https://bugs.webkit.org/show_bug.cgi?id=81312

Attachment 132214: Patch
https://bugs.webkit.org/attachment.cgi?id=132214&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review


LGTM.

>>> Source/WebCore/platform/PlatformKeyboardEvent.h:195
>>> +	     unsigned short m_unmodifiedCharacter;
>> 
>> It's initialized by event.character() in
PlatformKeyboardEvent::PlatformKeyboardEvent(const
BlackBerry::Platform::KeyboardEvent& event) in
PlatformKeyboardEventBlackBerry.cpp and used in
PluginView::handleKeyboardEvent(KeyboardEvent* event) in
PluginViewBlackBerry.cpp.
> 
> How is m_unmodifiedCharacter used? It seems to be set to zero and then?

Ah, this was not visible from the context, I saw it just now in the source
file, thanks.