[webkit-reviews] review denied: [Bug 78499] The auto-generated label in a <details> element without a <summary> is not keyboard accessible : [Attachment 132273] Proposed patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Arko Saha
<nghq36 at motorola.com>'s request for review:
Bug 78499: The auto-generated label in a <details> element without a <summary>
is not keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=78499

Attachment 132273: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=132273&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132273&action=review


This doesn't looks like right direction.
We shouldn't take the auto-generate summary as a special case if possible.

> Source/WebCore/html/HTMLDetailsElement.h:45
> +    virtual void focus(bool restorePreviousSelection = true) OVERRIDE;

Please don't give the default value on derived class. It can cause hard-to-find
error.