[webkit-reviews] review requested: [Bug 81502] x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue : [Attachment 132559] A speculative fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 02:19:29 PDT 2012


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 81502: x86 GCC bug triggers a compilation error in generated copy
constructor of CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Attachment 132559: A speculative fix
https://bugs.webkit.org/attachment.cgi?id=132559&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

It seems gcc (x86) somehow creates a broken copy constructor (used by HashSet<>
in the RenderTableSection class) because the CollapsedBorderValue class does
not have a copy constructor. This change adds a copy constructor to the
CollapsedBorderValue class so GCC can use it. (The "Google Chrome Linux" bot
can compile RenderTableSelection.cpp without errors when I locally applied this
change:
<ttp://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/bu
ilds/18598>.)

Regards,

Hironori Bono


More information about the webkit-reviews mailing list