[webkit-reviews] review granted: [Bug 79764] [Forms] The option element should not be form associated element. : [Attachment 132558] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 02:01:45 PDT 2012


Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 79764: [Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Attachment 132558: Patch 2
https://bugs.webkit.org/attachment.cgi?id=132558&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132558&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:1355
> +	   if (thisOptionElement->disabled() != otherOptionElement->disabled())

> +	       return false;

nit: We should use isEnabledFormControl() for consistency with
SelectorChecker.cpp.


More information about the webkit-reviews mailing list