[webkit-reviews] review denied: [Bug 79764] [Forms] The option element should not be form associated element. : [Attachment 132553] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 79764: [Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Attachment 132553: Patch 1
https://bugs.webkit.org/attachment.cgi?id=132553&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132553&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:1349
> +    if (element->hasTagName(optionTag))
> +	   return false;
> +

This is wrong.	It means we don't share a style for <option> elements in any
cases.
We should check:
 if both of m_element and element are optionTag,
    if enabled state is different, false
    if checked state is different, false
    otherwise, fall-through (means we can share the style)

> LayoutTests/fast/forms/resources/select-live-pseudo-selectors.js:55
> +    if (typeof(el) == 'string') {
> +	 el = document.getElementById(el);

inconsistent indentation.