[webkit-reviews] review granted: [Bug 81438] Add support for crossorigin attribute in script elements : [Attachment 132433] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 81438: Add support for crossorigin attribute in script elements
https://bugs.webkit.org/show_bug.cgi?id=81438

Attachment 132433: Patch
https://bugs.webkit.org/attachment.cgi?id=132433&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132433&action=review


> Source/WebCore/dom/ScriptElement.cpp:320
> +    if (m_element->fastHasAttribute(HTMLNames::crossoriginAttr)

So, this isn't 100% correct.  We should lock in the notion of whether this is a
crossorigin load when the load is initiated.  By re-checking the attribute
here, we might get a different value the second time.  That's an extremely
minor bug though.