[webkit-reviews] review requested: [Bug 81472] New renderer for SVGLineElement : [Attachment 132549] Draft patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 81472: New renderer for SVGLineElement
https://bugs.webkit.org/show_bug.cgi?id=81472

Attachment 132549: Draft patch
https://bugs.webkit.org/attachment.cgi?id=132549&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
This is a draft patch with a few ambiguous points.
In this approach I use GraphicsContext:drawLine() method for displaying the
lines. It's implemented on all platforms but I have a problem with them:
anitaliasing is setted by the member antiAliasingForRectsAndLines what is
default false. So the lines will be coarse. What should I do with this?

The second thing is RenderSVGLine::shapeDependentStrokeContains(). I have a
solution for this but it's never called because lines are considered as styled
elements and RenderSVGShape::strokeContains() will use the ancestor's function.
Any idea?

The last thing: what is the difference between filling and stroking lines?
There has any point having a line w/o stroke? (lines with 0 stroke aren't
visible) I guess they are the same so in this first patch I do the same both in
fillShape() and strokeShape(). (Hmm... or perhaps I should omit this function
because I defined an early return for lines with zero stroke-width at creating
so it shouldn't be called neither.)