[webkit-reviews] review granted: [Bug 81458] [chromium] synthesize wheel events for fling on main thread : [Attachment 132519] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 18 18:42:27 PDT 2012


James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 81458: [chromium] synthesize wheel events for fling on main thread
https://bugs.webkit.org/show_bug.cgi?id=81458

Attachment 132519: Patch
https://bugs.webkit.org/attachment.cgi?id=132519&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132519&action=review


OK

> Source/WebKit/chromium/src/WebViewImpl.cpp:1348
> +    else
> +	   m_gestureAnimation.clear();

indentation is still broken here. the "else" should be lined up with the "if"
it is the other branch for, not some other if statement. as is, this is very
confusing to read


More information about the webkit-reviews mailing list