[webkit-reviews] review canceled: [Bug 81326] Vertical flow support for OpenType fonts with the least platform dependencies : [Attachment 132470] OpenTypeVerticalData class and its related changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 18 14:37:40 PDT 2012


Koji Ishii <kojiishi at gmail.com> has canceled Koji Ishii <kojiishi at gmail.com>'s
request for review:
Bug 81326: Vertical flow support for OpenType fonts with the least platform
dependencies
https://bugs.webkit.org/show_bug.cgi?id=81326

Attachment 132470: OpenTypeVerticalData class and its related changes
https://bugs.webkit.org/attachment.cgi?id=132470&action=review

------- Additional Comments from Koji Ishii <kojiishi at gmail.com>
Changes from the previous patch:
* Fixed typo in ChangeLog.
* Changed openTypeTable() method to return PassRefPtr<SharedBuffer>.
* Changed ASSERT to LOG_ERROR when fonts are broken.
* Removed Copyright...Apple from all new files.
* Moved all OpenType types/structs to OpenType namespace.
* Reverted big-endian struct names to be compatible with OpenTypeUtilities.
* Changed conditions to early returns.
* Removed extra private: label.
* Changed variables names like "cb" and "cSomethign" to be more descriptive.

Questions still remains:
* Is Copyright okay with this change?
* Struct names are now compatible with OpenTypeUtilities but I didn't touch
OpenTypeUtilities to share the code yet. Should I do this? In a separate bug?
* Multi-character literals wasn't changed yet. See above comment, and I'll
change if that's the preference.
* Haven't change getVerticalTranslationsForGlyphs to use vectors yet. See
comment above, and I'll change after I got response.


More information about the webkit-reviews mailing list