[webkit-reviews] review granted: [Bug 81368] [Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration : [Attachment 132316] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 81368: [Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph
integration
https://bugs.webkit.org/show_bug.cgi?id=81368

Attachment 132316: Patch
https://bugs.webkit.org/attachment.cgi?id=132316&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132316&action=review


> Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp:58
> +    void setScale(float scale) { m_scale = scale; }

m_scale as well as this setScale method seems unused, now that we have the
transform node as a parent of this item.

> Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp:131
> +    if (m_contentsNode)

I think you can remove the if() here :)