[webkit-reviews] review denied: [Bug 81443] [WebSocket]The minimal number of bytes MUST be used to encode the length : [Attachment 132456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 17 13:57:05 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has denied joey <li.yin at intel.com>'s
request for review:
Bug 81443: [WebSocket]The minimal number of bytes MUST be used to encode the
length
https://bugs.webkit.org/show_bug.cgi?id=81443

Attachment 132456: Patch
https://bugs.webkit.org/attachment.cgi?id=132456&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #6)
> Does the test case need to be split another patch?

The test should be submitted along the patch.

I r- because you need to update the ChangeLog. A ChangeLog should be created
for the layout test.

I don't know WebSocket well enough to review this, I will leave the positive
review for someone else.


More information about the webkit-reviews mailing list