[webkit-reviews] review granted: [Bug 81286] [chromium] Unify the drawing logic for different layer types that output textures to the compositor : [Attachment 132151] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 19:01:44 PDT 2012


Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 81286: [chromium] Unify the drawing logic for different layer types that
output textures to the compositor
https://bugs.webkit.org/show_bug.cgi?id=81286

Attachment 132151: Patch
https://bugs.webkit.org/attachment.cgi?id=132151&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
R=me.  I totally agree that this patch unearths some mess, but all of that mess
was there before.  I think that the patch as-is is a net positive change and
should just get landed.

Also, I think CCTextureLayerImpl really is the right name here.  Many layers
are going to have external textures, but the plugin layer already uses an
internally generated texture id, as will video layers for software decode once
this change gets propagated to the main thread side.


More information about the webkit-reviews mailing list