[webkit-reviews] review denied: [Bug 81431] [chromium] Throttle overdraw metrics : [Attachment 132423] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 17:57:43 PDT 2012
James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81431: [chromium] Throttle overdraw metrics
https://bugs.webkit.org/show_bug.cgi?id=81431
Attachment 132423: Patch
https://bugs.webkit.org/attachment.cgi?id=132423&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
This seems like crazy overkill. There are only two callers to overdrawMetrics
- TiledLayerChromium and CCQuadCuller. Just keep a counter in CCQuadCuller as
a static local and for TiledLayerChromium stash a frame # somewhere and key off
of that. This should not be a 30kb+ patch that touches tons of files and has a
whole pile of new tests.
More information about the webkit-reviews
mailing list