[webkit-reviews] review granted: [Bug 81354] [chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread animations : [Attachment 132391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 15:51:48 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 81354: [chromium] Don't occlude on main-thread behind layers/surfaces with
impl-thread animations
https://bugs.webkit.org/show_bug.cgi?id=81354

Attachment 132391: Patch
https://bugs.webkit.org/attachment.cgi?id=132391&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132391&action=review


Looks good.  R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:91
> +static inline bool layerTransformsToScreenKnown(const CCLayerImpl* layer) {
return true; }

nit: unused param.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:98
> +static inline bool surfaceTransformsToScreenKnown(const CCRenderSurface*
surface) { return true; }

nit: unused param.


More information about the webkit-reviews mailing list