[webkit-reviews] review granted: [Bug 80882] flex-item-align: stretch should only grow, never shrink : [Attachment 132390] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 15:31:42 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 80882: flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882
Attachment 132390: Patch
https://bugs.webkit.org/attachment.cgi?id=132390&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132390&action=review
> Source/WebCore/rendering/RenderFlexibleBox.cpp:1014
> +void RenderFlexibleBox::alignChildStretch(RenderBox* child, LayoutUnit
lineCrossAxisExtent)
Nit: I find this method name awkward. It reads to me as if it's aligning the
stretch itself (which is nonsensical). applyChildStretch perhaps?
More information about the webkit-reviews
mailing list