[webkit-reviews] review granted: [Bug 81411] Add a land-from-url command : [Attachment 132387] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 14:58:21 PDT 2012
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 81411: Add a land-from-url command
https://bugs.webkit.org/show_bug.cgi?id=81411
Attachment 132387: Patch
https://bugs.webkit.org/attachment.cgi?id=132387&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132387&action=review
> Tools/Scripts/webkitpy/tool/commands/download.py:213
> + bug_id = urls.parse_bug_id(url)
> + if bug_id:
> + patches = tool.bugs.fetch_bug(bug_id).patches()
> + log("%s found on bug %s." % (pluralize("patch",
len(patches)), bug_id))
> + all_patches += patches
It's a bit odd that this works differently than land-from-bug. In person you
gave me a big speech about how land-from-bug is confusing and wrong, so I guess
that means you plan to fix land-from-bug? ;)
More information about the webkit-reviews
mailing list