[webkit-reviews] review granted: [Bug 81016] [mac/chromium] Change platform code to use pixelSnappedRect methods : [Attachment 131968] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 81016: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Attachment 131968: Patch
https://bugs.webkit.org/attachment.cgi?id=131968&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131968&action=review


Thank you for the reminder.  bug mail gets lost in the torrent...

> Source/WebCore/dom/Node.h:378
>      virtual LayoutRect getRect() const;
> +    IntRect getPixelSnappedRect() const { return
pixelSnappedIntRect(getRect()); }

I really don't like the "get" here.  "Rect" is also not very useful, as you
don't know what "rect" it means. :(