[webkit-reviews] review granted: [Bug 81387] MathML internals - factor code for almost anonymous blocks : [Attachment 132346] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 13:48:51 PDT 2012
Eric Seidel <eric at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 81387: MathML internals - factor code for almost anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=81387
Attachment 132346: Patch
https://bugs.webkit.org/attachment.cgi?id=132346&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132346&action=review
Nice to clean this up, thanks.
> Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:52
> +RenderMathMLBlock* RenderMathMLBlock::createAlmostAnonymousBlock(EDisplay
display)
Normally these sorts of functions would return PassOwnPtr, but the rendering
tree code isn't very consistent about that, sadly.
More information about the webkit-reviews
mailing list