[webkit-reviews] review denied: [Bug 79435] incorrect line-height for styled menulist (select tag) in windows theme (wincairo port) : [Attachment 132307] patch to fix line-height issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 13:29:48 PDT 2012
Benjamin Poulain <benjamin at webkit.org> has denied Lynn Neir
<lynn.neir at skype.net>'s request for review:
Bug 79435: incorrect line-height for styled menulist (select tag) in windows
theme (wincairo port)
https://bugs.webkit.org/show_bug.cgi?id=79435
Attachment 132307: patch to fix line-height issue
https://bugs.webkit.org/attachment.cgi?id=132307&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> > Source/WebCore/ChangeLog:13: You should remove the 'No new tests' and
either add and list tests, or explain why no new tests were possible.
[changelog/nonewtests] [5]
>
> style errors are false positives, style check ran fine for me.
Obviously not.
Check the file by yourself:
https://bug-79435-attachments.webkit.org/attachment.cgi?id=132307
More information about the webkit-reviews
mailing list