[webkit-reviews] review granted: [Bug 81057] Fix rounding and usage of LayoutUnits in RenderBoxModelObject : [Attachment 132126] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 12:47:20 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 81057: Fix rounding and usage of LayoutUnits in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=81057

Attachment 132126: Patch
https://bugs.webkit.org/attachment.cgi?id=132126&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
> However it turns out that this doesn't effect the visual representation at
all as it will be off by the full width (or height) of the image, resulting in
the same offset and thus the same rendering.

OK... Could you file about a bug about this craziness / the fact that
calculateBackgroundImageGeometry code should definitely be made less
error-prone?


More information about the webkit-reviews mailing list