[webkit-reviews] review granted: [Bug 81364] [BlackBerry] Input fields with id of e-mail and url should be styled as such. : [Attachment 132308] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Mike Fenton <mifenton at rim.com>'s
request for review:
Bug 81364: [BlackBerry] Input fields with id of e-mail and url should be styled
as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Attachment 132308: Patch
https://bugs.webkit.org/attachment.cgi?id=132308&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132308&action=review


Looks good.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:347
> +}

Above two function could use the same helper function, but you'd need to add a
bool or enum indicating to test Email or Url.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:191
> +	       else if ((type == InputTypeEmail || type == InputTypeURL) &&
autoCompleteState != DOMSupport::On)

else seems unnecessary here.