[webkit-reviews] review granted: [Bug 81105] [BlackBerry] Syncing up left over bits in Api from our local branch to upstream : [Attachment 132290] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 81105: [BlackBerry] Syncing up left over bits in Api from our local branch
to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Attachment 132290: Patch
https://bugs.webkit.org/attachment.cgi?id=132290&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132290&action=review


Looks good. Note that we can remove some WebCore:: prefixes, but that can be
done in a later patch.

>> Source/WebKit/blackberry/Api/BackingStore.cpp:2596
>> +	    WebCore::IntRect(WebCore::IntPoint(0, 0),
m_webPage->d->transformedViewportSize()));
> 
> You don't have to fix it in this patch, but indenting is strange. We also
prefer IntPoint::zero.

You don't have to fix it in this patch, but indenting is strange. We also
prefer IntPoint::zero.