[webkit-reviews] review granted: [Bug 81038] Update LayoutUnit usage in RenderListBox : [Attachment 131727] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 81038: Update LayoutUnit usage in RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=81038

Attachment 131727: Patch
https://bugs.webkit.org/attachment.cgi?id=131727&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131727&action=review


> Source/WebCore/ChangeLog:19
> +	   (WebCore::RenderListBox::panScroll):
EventHandler::currentMousePosition is an IntPoint,
> +	   so it doesn't require additional rounding in RenderListBox.

It would be nice to make such conversion fail at compile time when you change
the type of LayoutUnit to catch such unneeded copying.

> Source/WebCore/rendering/RenderListBox.cpp:425
> +    paintInfo.context->drawBidiText(itemFont, textRun,
roundedIntPoint(r.location()));

I was going to ask about why rounding and then I saw that's what
pixelSnappedIntRect does. I wonder if we could not make it more obvious that
pixelSnappedIntRect is doing a roundedIntPoint on the location...