[webkit-reviews] review granted: [Bug 81345] IDLParser.pm should support sequence<T> type : [Attachment 132270] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 81345: IDLParser.pm should support sequence<T> type
https://bugs.webkit.org/show_bug.cgi?id=81345

Attachment 132270: Patch
https://bugs.webkit.org/attachment.cgi?id=132270&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132270&action=review


>> Source/WebCore/bindings/scripts/IDLStructure.pm:106
>> +our $interfaceSelector = 'interface\s*((?:' . $extendedAttributeSyntax . '
)?)(' . $idlIdNs . '*)\s*(?::(\s*[^{]*))?{([-a-zA-Z0-9_"=\s(),;:\[\]<>&\|]*)';
> 
> It took me one hour to notice this change...:-) Maybe it is time to refactor
the IDL parser to a recursive parser.

We have a recursive version in Python, but I'm not sure we want to re-write
everything in Python...