[webkit-reviews] review granted: [Bug 80854] [Qt][Wk2] Assertion Failure and crash on file upload : [Attachment 132063] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 80854: [Qt][Wk2] Assertion Failure and crash on file upload
https://bugs.webkit.org/show_bug.cgi?id=80854

Attachment 132063: Patch
https://bugs.webkit.org/attachment.cgi?id=132063&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132063&action=review


r=me. The style nitpick and the member variable should be fixed before landing.


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:383
> +    openPanelResultListener = listenerRef;

It looks like this member variable could be removed, now that we process the
file picking "synchronously".

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:171
> +    QStringList fileList() const {return m_fileList; }

Missing space after opening {