[webkit-reviews] review requested: [Bug 75543] [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+ : [Attachment 132244] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 04:14:30 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 75543: [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=75543

Attachment 132244: New patch
https://bugs.webkit.org/attachment.cgi?id=132244&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This patch adds WebKitJavascriptResult boxed type containing information about
the result, the JSGlobalContextRef and the JSValueRef. That
WebKitJavascriptResult is returned by webkit_web_view_run_javascript_finish().
I've left the exceptions out for now, for the reasons explained in previous
comments. When bugs #79482 and #79918 are fixed, we can try to add the
exception information to the WebKitJavascriptResult using the console, or just
document that user should use the ::console-message signal to monitor script
exceptions.


More information about the webkit-reviews mailing list