[webkit-reviews] review denied: [Bug 81077] Add support for Intel compiler on Linux QT port. : [Attachment 131786] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Kwonjin Jeong
<gram at company100.net>'s request for review:
Bug 81077: Add support for Intel compiler on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

Attachment 131786: Patch
https://bugs.webkit.org/attachment.cgi?id=131786&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131786&action=review


These may seem like simple changes, but unfortunately an explanation as of
_why_ these changes are done is missing. A few comments below.

> Source/WebCore/Target.pri:3920
> +	       unix:icc: QMAKE_CXX = icpc

Why is this needed? Doesn't the qmake icc makespace in qtbase set QMAKE_CXX to
icpc?

> Tools/ChangeLog:11
> +	   * qmake/mkspecs/features/unix/icc.prf: Added.

Where is this used? I don't see a CONFIG += icc anywhere.