[webkit-reviews] review denied: [Bug 81300] Convert hasSpellingMarker to use Internals interface : [Attachment 132192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 00:18:29 PDT 2012


Hajime Morrita <morrita at google.com> has denied	review:
Bug 81300: Convert hasSpellingMarker to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=81300

Attachment 132192: Patch
https://bugs.webkit.org/attachment.cgi?id=132192&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132192&action=review


Thanks for taking this.
Please add export symbols to appropriate files. It will fix the build failure.

> Source/WebCore/testing/Internals.cpp:708
> +    if (!document || !document->frame() || !document->frame()->editor())

editor() is never null


More information about the webkit-reviews mailing list