[webkit-reviews] review granted: [Bug 81313] Move parse_bug_id into config/urls in preparation for re-use elsewhere. : [Attachment 132206] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 23:10:57 PDT 2012


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 81313: Move parse_bug_id into config/urls in preparation for re-use
elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=81313

Attachment 132206: Patch
https://bugs.webkit.org/attachment.cgi?id=132206&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132206&action=review


> Tools/Scripts/webkitpy/common/config/urls.py:56
> +def parse_bug_id(message):

message ?  Not sure what the best parameter name is here.

> Tools/Scripts/webkitpy/common/config/urls_unittest.py:35
> +    def test_parse_bug_id(self):

Should we add any multiline test cases since that's needed by at least one
caller.


More information about the webkit-reviews mailing list