[webkit-reviews] review granted: [Bug 79636] Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl : [Attachment 132178] hopefully fixed the mac build

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted  review:
Bug 79636: Move Notifications APIs from DOMWindow.idl to
DOMWindowNotifications.idl
https://bugs.webkit.org/show_bug.cgi?id=79636

Attachment 132178: hopefully fixed the mac build
https://bugs.webkit.org/attachment.cgi?id=132178&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132178&action=review


> Source/WebCore/notifications/DOMWindowNotifications.cpp:40
> +DOMWindowNotifications::DOMWindowNotifications(DOMWindow *window)

DOMWindow *window => DOMWindow* window

> Source/WebCore/notifications/DOMWindowNotifications.cpp:72
> +    if (m_notificationCenter)
> +	   return m_notificationCenter.get();
> +
> +    if (!m_window->isCurrentlyDisplayedInFrame())
> +	   return 0;

You've reversed the order of these to checks.  It's important to return 0 when
the window is not currently displayed in a frame.

> Source/WebCore/notifications/DOMWindowNotifications.h:50
> +    DOMWindowNotifications(DOMWindow*);

Please add the explicit keyword to one-argument constructor.s