[webkit-reviews] review granted: [Bug 79652] Add Conditions of Antialias for Drawing Lines : [Attachment 129139] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 15 22:23:37 PDT 2012
Hajime Morrita <morrita at google.com> has granted younghwan cho
<yhwan.cho at samsung.com>'s request for review:
Bug 79652: Add Conditions of Antialias for Drawing Lines
https://bugs.webkit.org/show_bug.cgi?id=79652
Attachment 129139: proposed patch
https://bugs.webkit.org/attachment.cgi?id=129139&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129139&action=review
r+ for now due to cr-linux redness.
These redness means that this change actually affects the rendering result,
doesn't it?
> Source/WebCore/rendering/RenderBoxModelObject.cpp:2869
> + return !context->getCTM().isIdentityOrTranslationOrFlipped() ||
!context->getCTM().isIntegerTranslation() ||
!context->getCTM().isScaledByIntegerValue();
Some checks are apparently verbose.
More information about the webkit-reviews
mailing list