[webkit-reviews] review granted: [Bug 81214] [Performance] Optimize innerHTML and outerHTML : [Attachment 132172] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 81214: [Performance] Optimize innerHTML and outerHTML
https://bugs.webkit.org/show_bug.cgi?id=81214

Attachment 132172: Patch
https://bugs.webkit.org/attachment.cgi?id=132172&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132172&action=review


The old code looks kind of silly after this patch.  :)

> Source/WebCore/editing/MarkupAccumulator.cpp:156
>  void MarkupAccumulator::concatenateMarkup(StringBuilder& result)

This function appears unused.  Perhaps we can remove it?

> Source/WebCore/editing/MarkupAccumulator.h:81
>      static size_t totalLength(const Vector<String>&);

Does this function have any more callers?  Perhaps we can remove it.