[webkit-reviews] review denied: [Bug 81196] IETC HTM5: verify HTMLDatalistElement. instanceof HTMLDataListElement fails. : [Attachment 132004] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 18:09:07 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 81196: IETC HTM5: verify HTMLDatalistElement. instanceof
HTMLDataListElement fails.
https://bugs.webkit.org/show_bug.cgi?id=81196

Attachment 132004: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=132004&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132004&action=review


> LayoutTests/ChangeLog:13
> +	   * fast/forms/datalist_prototype_constructor-expected.txt: Added.
> +	   * fast/forms/datalist_prototype_constructor.html: Added.

We usually use '-' to concatenate words, not '_'.

The test looks a copy of IETC code.  Is the license of the IETC test compatible
with WebKit?

You need to update other tests such as
LayoutTests/fast/dom/window/window-properties.html.


More information about the webkit-reviews mailing list